[ 
https://issues.apache.org/jira/browse/HIVE-14055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342466#comment-15342466
 ] 

Sergio Peña commented on HIVE-14055:
------------------------------------

Hey Sergey, sorry I am still against the null value. I was thinking that if a 
filter push down couldn't be done, then the method should throw an exception 
with the reason of that. While I was running some tests with HIVE-14063, I did 
a test you mentioned about falling-back to ORM if direct-sql fails, and ORM 
also failed but with an exception returned by {{getNumPartitionsViaOrmFilter}} 
due to problems with the filter. In this scenario, I could know exactly what 
the problem was.

In my opinion, I think that we should throw a checked exception in case an 
internal error happens, and let the caller decide what to do with it. 
[~ashutoshc] [~sushanth] what do you think about this? I'd like to know other 
opinions.

> directSql - getting the number of partitions is broken
> ------------------------------------------------------
>
>                 Key: HIVE-14055
>                 URL: https://issues.apache.org/jira/browse/HIVE-14055
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-14055.01.patch, HIVE-14055.patch
>
>
> Noticed while looking at something else. If the filter cannot be pushed down 
> it just returns 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to