[ 
https://issues.apache.org/jira/browse/HIVE-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360690#comment-15360690
 ] 

Pengcheng Xiong commented on HIVE-14143:
----------------------------------------

[~nemon], I think we only need to see if it is possible to improve your first 
patch regarding the "// Set READ_ALL_COLUMNS to false
"
Right now, you have 
{code}
111         if (ids.size() > 0) {
112           // Set READ_ALL_COLUMNS to false
113           conf.setBoolean(READ_ALL_COLUMNS, false);
114         }
113       }     115       }
{code}
I would like to know if it is possible to change it to the following to be 
consistent with the definition we have in TableScanDesc.java:
{code}
111         if (ids == null || ids.size() != *sizeOfColumnsInTableScan*) {
112           // Set READ_ALL_COLUMNS to false
113           conf.setBoolean(READ_ALL_COLUMNS, false);
114         }
113       }     115       }
{code}

Then you do not need to modify the TestColumnProjectionUtils.java. Thanks.

> RawDataSize of RCFile is zero after analyze 
> --------------------------------------------
>
>                 Key: HIVE-14143
>                 URL: https://issues.apache.org/jira/browse/HIVE-14143
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics
>    Affects Versions: 1.2.1, 2.1.0
>            Reporter: Nemon Lou
>            Assignee: Nemon Lou
>            Priority: Minor
>         Attachments: HIVE-14143.1.patch, HIVE-14143.patch
>
>
> After running the following analyze command ,rawDataSize becomes zero for 
> rcfile tables.
> {noformat}
>  analyze table RCFILE_TABLE compute statistics ;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to