[
https://issues.apache.org/jira/browse/HIVE-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364841#comment-15364841
]
Sahil Takiar commented on HIVE-14169:
-------------------------------------
Hey! It shouldn't affect HIVE-14135
According to
https://issues.apache.org/jira/browse/HIVE-7224?focusedCommentId=15363688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15363688
the width calculation is only used when Beeline prints its output using a
{{TableOutputFormat}}. It seems there are multiple formats the Beeline can
print its output, including CSV, TSV, etc.
({{org.apache.hive.beeline.OutputFormat}} is the interface to control this).
The goal for this JIRA is to just skip the width calculation if
{{TableOutputFormat}} is not used.
> Beeline Row printing should only calculate the width if TableOutputFormat is
> used
> ---------------------------------------------------------------------------------
>
> Key: HIVE-14169
> URL: https://issues.apache.org/jira/browse/HIVE-14169
> Project: Hive
> Issue Type: Sub-task
> Components: Beeline
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
>
> * When Beeline prints out a {{ResultSet}} to stdout it uses the
> {{BeeLine.print}} method
> * This method takes the {{ResultSet}} from the completed query and uses a
> specified {{OutputFormat}} to print the rows (by default it uses
> {{TableOutputFormat}})
> * The {{print}} method also wraps the {{ResultSet}} into a {{Rows}} class
> (either a {{IncrementalRows}} or a {{BufferedRows}} class)
> * The {{Rows}} class will calculate the optimal width that each row in the
> {{ResultSet}} should be displayed with
> * However, this width is only relevant / used by {{TableOutputFormat}}
> We should modify the logic so that the width is only calculated if
> {{TableOutputFormat}} is used. This will save CPU cycles when printing
> records out to the user.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
