[
https://issues.apache.org/jira/browse/HIVE-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378441#comment-15378441
]
Siddharth Seth commented on HIVE-9756:
--------------------------------------
{code}
+ Field field =
callableWithNdc.getClass().getSuperclass().getDeclaredField("ndcStack");
+ field.setAccessible(true);
+ Stack ndcStack = (Stack) field.get(callableWithNdc);
{code}
Can this be replaced by "Stack ndcStack = NDC.cloneStack();" ?
This is being done because Tez works with the NDC and log4j1, correct?
Also
{code}
ndcStack.push(dagId);
ndcStack.push(queryId);
ndcStack.push(fragmentId);
{code}
with
NDC.push(dagId); NDC.push ...
There's a lot happening in TaskRunnerCallable between the MDC setup and try {}
finally {clear} block. Think we should move everything after the NDC/MDC set
into it's own try/finally block. (Similar to the CallerWithNDC?).
MDC/NDC vs log4j2 ThreadContext
(https://logging.apache.org/log4j/2.x/manual/thread-context.html) - does it
matter?
> LLAP: use log4j 2 for llap (log to separate files, etc.)
> --------------------------------------------------------
>
> Key: HIVE-9756
> URL: https://issues.apache.org/jira/browse/HIVE-9756
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 2.0.0
> Reporter: Gunther Hagleitner
> Assignee: Prasanth Jayachandran
> Attachments: HIVE-9756.1.patch, HIVE-9756.2.patch, HIVE-9756.3.patch,
> HIVE-9756.4.patch, HIVE-9756.4.patch, HIVE-9756.5.patch, HIVE-9756.6.patch,
> HIVE-9756.7.patch
>
>
> For the INFO logging, we'll need to use the log4j-jcl 2.x upgrade-path to get
> throughput friendly logging.
> http://logging.apache.org/log4j/2.0/manual/async.html#Performance
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
