[ 
https://issues.apache.org/jira/browse/HIVE-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427294#comment-15427294
 ] 

Owen O'Malley commented on HIVE-14566:
--------------------------------------

I really think that we need to make a context object for passing information 
down to the tree reader. Otherwise, we are going to get killed by adding 
parameters to this, especially when ORC makes it out of Hive.

How about something like:

{code}
public interface Context {
  SchemaEvolution getEvolution();
  boolean skipCorrupt();
  String writerTimezone();
}

public static TreeReader createTreeReader(TypeDescription readerType,
                                                                      Context 
context) throws IOException {
{code}

Then we can add new information without making sure a huge change that touches 
all of the methods.

> LLAP IO reads timestamp wrongly
> -------------------------------
>
>                 Key: HIVE-14566
>                 URL: https://issues.apache.org/jira/browse/HIVE-14566
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>    Affects Versions: 2.1.0, 2.0.1, 2.2.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Critical
>         Attachments: HIVE-14566.1.patch, HIVE-14566.2.patch
>
>
> HIVE-10127 is causing incorrect results when orc_merge12.q is run in llap.
> It reads timestamp wrongly.
> {code:title=LLAP IO Enabled}
> hive> select atimestamp1 from alltypesorc3xcols limit 10;
> OK
> 1969-12-31 15:59:46.674
> NULL
> 1969-12-31 15:59:55.787
> 1969-12-31 15:59:44.187
> 1969-12-31 15:59:50.434
> 1969-12-31 16:00:15.007
> 1969-12-31 16:00:07.021
> 1969-12-31 16:00:04.963
> 1969-12-31 15:59:52.176
> 1969-12-31 15:59:44.569
> {code}
> {code:title=LLAP IO Disabled}
> hive> select atimestamp1 from alltypesorc3xcols limit 10;
> OK
> 1969-12-31 15:59:46.674
> NULL
> 1969-12-31 15:59:55.787
> 1969-12-31 15:59:44.187
> 1969-12-31 15:59:50.434
> 1969-12-31 16:00:14.007
> 1969-12-31 16:00:06.021
> 1969-12-31 16:00:03.963
> 1969-12-31 15:59:52.176
> 1969-12-31 15:59:44.569
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to