[ 
https://issues.apache.org/jira/browse/HIVE-13974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428828#comment-15428828
 ] 

Owen O'Malley commented on HIVE-13974:
--------------------------------------

I believe this patch is already handled by ORC-54, which was committed already.

In particular, look in 
https://github.com/apache/orc/blob/master/java/core/src/test/org/apache/orc/impl/TestSchemaEvolution.java
 
for testAddFieldEndOfStruct and testAcidPositionSubstructure.

It also fixed the case that a user hit where the SARG columns weren't being 
mapped properly.

Are there still gaps or bugs? Can you make a unit test case for ORC that 
demonstrates the gap or bug in ORC's master branch?

> ORC Schema Evolution doesn't support add columns to non-last STRUCT columns
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-13974
>                 URL: https://issues.apache.org/jira/browse/HIVE-13974
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive, ORC, Transactions
>    Affects Versions: 1.3.0, 2.1.0, 2.2.0
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Blocker
>             Fix For: 2.2.0, 2.1.1
>
>         Attachments: HIVE-13974.01.patch, HIVE-13974.02.patch, 
> HIVE-13974.03.patch, HIVE-13974.04.patch, HIVE-13974.05.WIP.patch, 
> HIVE-13974.06.patch, HIVE-13974.07.patch, HIVE-13974.08.patch, 
> HIVE-13974.09.patch, HIVE-13974.091.patch, HIVE-13974.092.patch, 
> HIVE-13974.093.patch, HIVE-13974.094.patch, HIVE-13974.095.patch, 
> HIVE-13974.096.patch, HIVE-13974.097.patch, HIVE-13974.098.patch
>
>
> Currently, the included columns are based on the fileSchema and not the 
> readerSchema which doesn't work for adding columns to non-last STRUCT data 
> type columns.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to