[
https://issues.apache.org/jira/browse/HIVE-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475355#comment-15475355
]
Gopal V commented on HIVE-14542:
--------------------------------
LGTM - +1.
Minor nit: there's no break; after the last case statement - that might trip up
the next person who patches it.
> VirtualColumn::equals() should use object equality
> --------------------------------------------------
>
> Key: HIVE-14542
> URL: https://issues.apache.org/jira/browse/HIVE-14542
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor, Transactions
> Affects Versions: 0.14.0
> Reporter: Gopal V
> Assignee: Eugene Koifman
> Priority: Minor
> Attachments: HIVE-14542.3.patch, HIVE-14542.4.patch,
> HIVE-14542.5.patch, HIVE-14542.6.patch, HIVE-14542.patch, virtual-columns.png
>
>
> The VirtualColumn() constructor is private and is only called to initialize 5
> static objects.
> !virtual-columns.png!
> There's no reason for VirtualColumn::equals() to do a deep type inspection
> for each access of a complex type like ROW__ID.
> {code}
> else if(vc.equals(VirtualColumn.ROWID)) {
> if(ctx.getIoCxt().getRecordIdentifier() == null) {
> vcValues[i] = null;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
