[
https://issues.apache.org/jira/browse/HIVE-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491003#comment-15491003
]
Vihang Karajgaonkar commented on HIVE-13589:
--------------------------------------------
Hi [~Ke Jia] You will have to modify the constructCmd too like seen in my
review. I think that is the reason why TestBeeLineWithArgs test is failing
with your latest patch. The connect(String cmd) method in Commands.java will
not work with space separated arguments when the password is null. That is
reason why we need to change to implementation of constructCmd method to use
';' separated url.
It seems that most of the changes and test cases in the latest patch are same
as changes from my review. Since that patch is already complete with test cases
and we already have a review for it, why not just use that patch instead of
reinventing the wheel. [~Ke Jia] and [~Ferd] you can review the patch and I can
incorporate any suggestions which you may have. Please let me know if that is
okay.
> beeline - support prompt for password with '-u' option
> ------------------------------------------------------
>
> Key: HIVE-13589
> URL: https://issues.apache.org/jira/browse/HIVE-13589
> Project: Hive
> Issue Type: Bug
> Components: Beeline
> Reporter: Thejas M Nair
> Assignee: Ke Jia
> Fix For: 2.2.0
>
> Attachments: HIVE-13589.1.patch, HIVE-13589.2.patch,
> HIVE-13589.3.patch, HIVE-13589.4.patch, HIVE-13589.5.patch,
> HIVE-13589.6.patch, HIVE-13589.7.patch, HIVE-13589.8.patch
>
>
> Specifying connection string using commandline options in beeline is
> convenient, as it gets saved in shell command history, and it is easy to
> retrieve it from there.
> However, specifying the password in command prompt is not secure as it gets
> displayed on screen and saved in the history.
> It should be possible to specify '-p' without an argument to make beeline
> prompt for password.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
