[ https://issues.apache.org/jira/browse/HIVE-9423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517298#comment-15517298 ]
Chaoyu Tang edited comment on HIVE-9423 at 9/26/16 2:12 PM: ------------------------------------------------------------ Yeah, it makes sense. This patch improves the usability though we might have missed some error case (e.g. TTransportException: java.net.SocketException: Connection reset") which is also resulted from exceeding the max worker #. Do the TTransportException like TTransportException.UNKNOWN or TTransportException.END_OF_FILE only happen during connection time? They could also happen during execution time (after the connection), right? If so, are the messages like "Unknown HS2 problem when connecting to Thrift server" a little confusing since they are particular for connection issues? was (Author: ctang.ma): Yeah, it makes sense. This patch improves the usability though we might have missed some error case (e.g. TTransportException: java.net.SocketException: Connection reset") which is also resulted from exceeding the max worker #. Do the TTransportException like TTransportException.UNKNOWN or TTransportException.END_OF_FILE only happen during connection time? They could also happen during execution time (after the connection), right? If so, is the message like "Unknown HS2 problem when connecting to Thrift server" be a little confusing? > HiveServer2: Provide the user with different error messages depending on the > Thrift client exception code > --------------------------------------------------------------------------------------------------------- > > Key: HIVE-9423 > URL: https://issues.apache.org/jira/browse/HIVE-9423 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Affects Versions: 0.12.0, 0.13.0, 0.14.0, 0.15.0 > Reporter: Vaibhav Gumashta > Assignee: Peter Vary > Attachments: HIVE-9423.2.patch, HIVE-9423.3.patch, HIVE-9423.4.patch, > HIVE-9423.patch > > > An example of where it is needed: it has been reported that when # of client > connections is greater than {{hive.server2.thrift.max.worker.threads}}, > HiveServer2 stops accepting new connections and ends up having to be > restarted. This should be handled more gracefully by the server and the JDBC > driver, so that the end user gets aware of the problem and can take > appropriate steps (either close existing connections or bump of the config > value or use multiple server instances with dynamic service discovery > enabled). Similarly, we should also review the behaviour of background thread > pool to have a well defined behavior on the the pool getting exhausted. > Ideally implementing some form of general admission control will be a better > solution, so that we do not accept new work unless sufficient resources are > available and display graceful degradation under overload. -- This message was sent by Atlassian JIRA (v6.3.4#6332)