[
https://issues.apache.org/jira/browse/HIVE-13098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Shelukhin updated HIVE-13098:
------------------------------------
Attachment: HIVE-13098.WIP2.patch
This patch handles many more paths.
I think it's close to being ready to review/commit..
The main question is how to handle OIs, cause OI static giant global methods
are just too general. I almost wonder if I should give up and add a threadlocal
just for that case in the static OI class that would read config once per
thread... however, that will make the config global for that case. We can
document that config is HS2-wide and cannot be changed per query and do a
followup.
As for write paths, these would need to be handled on case by case basis cause
their initialization is obscure. I started on the ORC write path, but put the
config in the wrong place for master (it's the right place for branch-1). I
will finish that.
[~jdere] [~ashutoshc] do you want to take a look? 95% of the changes are just
propagating the stupid config. Main changes are in HiveDecimal and
HiveDecimalOverflow classes.
> Add a strict check for when the decimal gets converted to null due to
> insufficient width
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-13098
> URL: https://issues.apache.org/jira/browse/HIVE-13098
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-13098.WIP.patch, HIVE-13098.WIP2.patch
>
>
> When e.g. 999999 is selected as decimal(5,0), the result is null. This can be
> problematic, esp. if the data is written to a table and lost without the user
> realizing it. There should be an option to error out in such cases instead;
> it should probably be on by default and the error message should instruct the
> user on how to disable it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
