[
https://issues.apache.org/jira/browse/HIVE-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15555535#comment-15555535
]
Ashutosh Chauhan commented on HIVE-14908:
-----------------------------------------
yeah.. benefits are worth the upgrade.
Patch LGTM +1
> Upgrade ANTLR to 3.5.2
> ----------------------
>
> Key: HIVE-14908
> URL: https://issues.apache.org/jira/browse/HIVE-14908
> Project: Hive
> Issue Type: Sub-task
> Reporter: Pengcheng Xiong
> Assignee: Pengcheng Xiong
> Attachments: HIVE-14908.01.patch
>
>
> Antlr v4 is also available but it does not support "->" which is widely used
> in our grammar. Antlr 3.5.2 is the latest v3 version. It will reduce the code
> size:
> {code}
> Here is summary of current parser code size
> 422345 HiveLexer.java
> 2436601 HiveParser.java
> 814184 HiveParser_FromClauseParser.java
> 2705920 HiveParser_IdentifiersParser.java
> 777665 HiveParser_SelectClauseParser.java
> After change, it will become
> 319589 HiveLexer.java
> 1853104 HiveParser.java
> 574156 HiveParser_FromClauseParser.java
> 1799195 HiveParser_IdentifiersParser.java
> 587305 HiveParser_SelectClauseParser.java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
