[ 
https://issues.apache.org/jira/browse/HIVE-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572001#comment-15572001
 ] 

Illya Yalovyy commented on HIVE-14927:
--------------------------------------

[~aihuaxu], [~ashutoshc], [~ctang.ma], [~szehon]

Could you please take a look at this CR?
https://reviews.apache.org/r/52743/


> Remove code duplication from tests in TestLdapAtnProviderWithMiniDS
> -------------------------------------------------------------------
>
>                 Key: HIVE-14927
>                 URL: https://issues.apache.org/jira/browse/HIVE-14927
>             Project: Hive
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Illya Yalovyy
>            Assignee: Illya Yalovyy
>         Attachments: HIVE-14927.1.patch
>
>
> * Extract inner class User and implement a proper builder for it.
> * Extract all common code to LdapAuthenticationTestCase class 
>   ** setting up the test case
>    ** executing test case
>    ** result validation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to