Pengcheng Xiong commented on HIVE-14925:

[~rkamoor], there are several test cases failing, could u take a look at them? 
And, as [~rajesh.balamohan] suggested, we need to add a test case for the 
patch. If q tests are hard to add, maybe you can add a JUnit test with some 
artificial delay, e.g., thread.sleep, etc to expose the problem and prove the 
benefit of your patch. Thanks again for your efforts.

> MSCK repair table hang while running with multi threading enabled
> -----------------------------------------------------------------
>                 Key: HIVE-14925
>                 URL: https://issues.apache.org/jira/browse/HIVE-14925
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 2.2.0
>            Reporter: Ratheesh Kamoor
>            Assignee: Ratheesh Kamoor
>            Priority: Critical
>             Fix For: 2.2.0
>         Attachments: HIVE-14925.patch
> MSCK REPAIR TABLE hanging while running with multi-threading enabled 
> (default). I think it is because of a major design flaw in how thread pool 
> implemented in HiveMetaSoreChecker class / checkPartitionDirs method. This 
> method has a thread pool which register Callable but callable makes a 
> recursive call to checkPartitionDirs method again. This code will hang when 
> number of directories is more than thread pool size. 

This message was sent by Atlassian JIRA

Reply via email to