[ 
https://issues.apache.org/jira/browse/HIVE-11957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15576869#comment-15576869
 ] 

Eugene Koifman edited comment on HIVE-11957 at 10/15/16 12:17 AM:
------------------------------------------------------------------

I missed this the last time, but I don't think you should make new fields in 
Thrift required - it will generally break old clients.
(it may be OK in this case since this object always originates on the server 
which should be upgraded before clients but it seems fragile to rely on this)

Also, I think putting the new fields in the output as you had them in patch 5 
makes more sense.  There is no relationship between thrift struct order and 
display order


was (Author: ekoifman):
I missed this the last time, but I don't think you should make new fields in 
Thrift required - it will generally break old clients.
(it may be OK in this case since this object always originates on the server 
which should be upgraded before clients but it seems fragile to rely on this)

Also, I think putting the new files in the output as you had them in patch 5 
makes more sense.  There is no relationship between thrift struct order and 
display order

> SHOW TRANSACTIONS should show queryID/agent id of the creator
> -------------------------------------------------------------
>
>                 Key: HIVE-11957
>                 URL: https://issues.apache.org/jira/browse/HIVE-11957
>             Project: Hive
>          Issue Type: Improvement
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Wei Zheng
>         Attachments: HIVE-11957.1.patch, HIVE-11957.2.patch, 
> HIVE-11957.3.patch, HIVE-11957.4.patch, HIVE-11957.5.patch, HIVE-11957.6.patch
>
>
> this would be very useful for debugging
> should also include heartbeat/create timestamps
> would be nice to support some filtering/sorting options, like sort by create 
> time, agent id. filter by table, database, etc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to