Pengcheng Xiong commented on HIVE-14957:

[~jcamachorodriguez], yes, i agree that a test case will absolutely be better. 
I have already considered this when I found the issue. My concern is that this 
bug will be exposed only when we do a project-remove (see my patch for 
intersect-merge rule). It is not reproducible on current master according to 
our current sequence of optimization rules. Thus, I would prefer just backport 
the code change without q tests. And for the future release, HIVE-12765 has 
test cases. How does that sound to you? 

> HiveSortLimitPullUpConstantsRule misses branches when parent operator is Union
> ------------------------------------------------------------------------------
>                 Key: HIVE-14957
>                 URL: https://issues.apache.org/jira/browse/HIVE-14957
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>         Attachments: HIVE-14957.01.patch, HIVE-14957.02.patch
> {code}
> call.transformTo(parent.copy(parent.getTraitSet(), 
> ImmutableList.of(relBuilder.build())));
> {code}
> When parent is an union operator which has 2 inputs, the parent.copy will 
> only copy the one that has SortLimit and ignore the other branches.

This message was sent by Atlassian JIRA

Reply via email to