[ 
https://issues.apache.org/jira/browse/HIVE-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15579041#comment-15579041
 ] 

Gopal V commented on HIVE-14981:
--------------------------------

[~mmccline]: LGTM, +1 tests pending.

I don't think the following golden file change is a problem, but it would be 
good to clarify on this JIRA how the 3 turns into 25?

{code}
                         Group By Operator
                           aggregations: count(1)
                           Group By Vectorization:
-                              aggregators: 
VectorUDAFCount(ConstantVectorExpression(val 1) -> 3:long) -> bigint
+                              aggregators: 
VectorUDAFCount(ConstantVectorExpression(val 1) -> 25:long) -> bigint
{code}

Is that the column id # in lieu of a constant key like 0?

> Eliminate unnecessary MapJoin restriction in HIVE-11394
> -------------------------------------------------------
>
>                 Key: HIVE-14981
>                 URL: https://issues.apache.org/jira/browse/HIVE-14981
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>    Affects Versions: 2.2.0
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>             Fix For: 2.2.0
>
>         Attachments: HIVE-14981.01.patch
>
>
> No Empty Key restriction for Native Vector MapJoin added with HIVE-11394 is 
> unnecessary.  It caused Llap orc_llap.q test to timeout on Hive QA because 
> regular VectorMapJoinOperator is too slow.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to