[ 
https://issues.apache.org/jira/browse/HIVE-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614226#comment-15614226
 ] 

Wei Zheng commented on HIVE-15087:
----------------------------------

[~ekoifman] I'm not sure if I understand you correctly. I'm already extending 
AcidOperationalProperties and TransactionalValidationListener by adding a third 
valid value "insert_only", besides the existing two "default" and "legacy". Do 
you mean we shouldn't use this approach?

[~sershe] Thanks for introducing the isFullAcidTable. The reason I left some of 
those isAcidTable be is for the same reason. Those are the "actual" ACID tables 
and we shouldn't apply mm logic on them. But yes now it's more clearer. Btw all 
those tests passed when I checked in :)

> integrate MM tables into ACID: replace "hivecommit" property with ACID 
> property
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-15087
>                 URL: https://issues.apache.org/jira/browse/HIVE-15087
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Wei Zheng
>            Assignee: Wei Zheng
>             Fix For: hive-14535
>
>         Attachments: HIVE-15087.1.patch
>
>
> Previously declared DDL
> {code}
> create table t1 (key int, key2 int)  tblproperties("hivecommit"="true");
> {code}
> should be replaced with:
> {code}
> create table t1 (key int, key2 int)  tblproperties("transactional"="true", 
> "transactional_properties"="insert_only");
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to