[
https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648020#comment-15648020
]
Peter Vary commented on HIVE-15051:
-----------------------------------
Made a minimal patch for beeline module, here is the test result:
{code}
Total Elapsed time: 3m 49s
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | hivetest4tests | 0m 00s | The patch appears to include 1 new
| | | | or modified test files.
| +1 | @author | 0m 00s | The patch does not contain any
| | | | @author tags.
| +1 | mvninstall | 0m 28s | passed
| +1 | checkstyle | 0m 16s | passed
| 0 | findbugs | 0m 31s | beeline in has 65 extant Findbugs
| | | | warnings.
| +1 | javadoc | 0m 17s | passed
| +1 | mvninstall | 0m 26s | the patch passed
| -1 | checkstyle | 0m 16s | beeline: The patch generated 9 new +
| | | | 0 unchanged - 0 fixed = 9 total (was
| | | | 0)
| -1 | whitespace | 0m 00s | The patch has 1 line(s) that end in
| | | | whitespace. Use git apply
| | | | --whitespace=fix.
| -1 | whitespace | 0m 00s | The patch 1 line(s) with tabs.
| +1 | xml | 0m 01s | The patch has no ill-formed XML
| | | | file.
| -1 | findbugs | 0m 39s | beeline generated 2 new + 65
| | | | unchanged - 0 fixed = 67 total (was
| | | | 65)
| -1 | javac | 0m 39s | beeline generated 2 new + 65
| | | | unchanged - 0 fixed = 67 total (was
| | | | 65)
| -1 | javadoc | 0m 16s | beeline generated 1 new + 52
| | | | unchanged - 0 fixed = 53 total (was
| | | | 52)
| -1 | asflicense | 0m 20s | The patch generated 15 ASF License
| | | | warnings.
| | | 3m 49s |
Reason | Tests
FindBugs | module:beeline
| add.CheckError.get() may expose internal representation by
returning CheckError.data At CheckError.java:by returning CheckError.data At
CheckError.java:[line 18]
| Unwritten field:CheckError.java:[line 18]
|| Subsystem || Report/Notes ||
============================================================================
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle xml
|
| uname | Darwin pvary.local 15.3.0 Darwin Kernel Version 15.3.0: Thu Dec 10
18:40:58 PST 2015; root:xnu-3248.30.4~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality |
/Users/petervary/dev/upstream/hive/dev-support/hive-personality.sh |
| git revision | / 0757a11 |
| Default Java | 1.8.0_92 |
| findbugs | v3.0.1 |
| checkstyle | /private/tmp/yetus-24765.18993/diff-checkstyle-beeline.txt |
| whitespace | /private/tmp/yetus-24765.18993/whitespace-eol.txt |
| whitespace | /private/tmp/yetus-24765.18993/whitespace-tabs.txt |
| findbugs | /private/tmp/yetus-24765.18993/new-findbugs-beeline.html |
| javac | /private/tmp/yetus-24765.18993/new-findbugs-beeline.html |
| javadoc | /private/tmp/yetus-24765.18993/diff-javadoc-javadoc-beeline.txt |
| asflicense | /private/tmp/yetus-24765.18993/patch-asflicense-problems.txt |
| modules | C: beeline U: beeline |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{code}
> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
> Key: HIVE-15051
> URL: https://issues.apache.org/jira/browse/HIVE-15051
> Project: Hive
> Issue Type: Sub-task
> Components: Testing Infrastructure
> Reporter: Peter Vary
> Assignee: Peter Vary
>
> Find a way to integrate code analysis tools like findbugs, rat checks to
> PreCommit tests, thus removing the burden from reviewers to check the code
> style and other checks which could be done by code.
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific
> parallel test framework.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
