[ 
https://issues.apache.org/jira/browse/HIVE-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15651254#comment-15651254
 ] 

Peter Vary commented on HIVE-15090:
-----------------------------------

Hi [~thejas],

I was thinking about the same lines as you, but finally decided against it.
My reasoning was that the METASTORE_CLUSTER_DELEGATION_TOKEN_STORE_CLS is a 
configuration variable and could be set by the administrator to any class, that 
is why we will never be able to handle every future exception here correctly. 
So finally I decided to stick to a clean, easily understandable solution rather 
than create a partial solution for the DBTokenStore only.

Since this one is already committed to master, I think if we find a better 
approach I think we should open another jira to handle it.
I would be happy to help out there too.

Thanks again for taking a look at this!

Peter

> Temporary DB failure can stop ExpiredTokenRemover thread
> --------------------------------------------------------
>
>                 Key: HIVE-15090
>                 URL: https://issues.apache.org/jira/browse/HIVE-15090
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 1.3.0, 2.1.0, 2.0.1, 2.2.0
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>             Fix For: 2.2.0
>
>         Attachments: HIVE-15090.2-branch-2.1.patch, HIVE-15090.2.patch, 
> HIVE-15090.2.patch, HIVE-15090.patch
>
>
> In HIVE-13090 we decided that we should not close the metastore if there is 
> an unexpected exception during the expired token removal process, but that 
> fix leaves a running metastore without ExpiredTokenRemover thread.
> To fix this I will move the catch inside the running loop, and hope the 
> thread could recover from the exception



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to