[ https://issues.apache.org/jira/browse/HIVE-13966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15685980#comment-15685980 ]
Lefty Leverenz commented on HIVE-13966: --------------------------------------- Doc note: This adds *hive.metastore.transactional.event.listeners* to HiveConf.java and gives a description for *hive.metastore.event.listeners* so the wiki needs to be updated. * [Configuration Properties -- MetaStore | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-MetaStore] (add a link to hive.metastore.transactional.event.listeners in the section introduction) ** [Configuration Properties -- MetaStore -- hive.metastore.event.listeners | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.metastore.event.listeners] * [Configuration Properties -- Transactions | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-Transactions] ** [Configuration Properties -- Transactions -- hive.metastore.transactional.event.listeners | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.metastore.transactional.event.listeners] (this link won't work until the parameter is documented) Added a TODOC2.2 label. > DbNotificationListener: can loose DDL operation notifications > ------------------------------------------------------------- > > Key: HIVE-13966 > URL: https://issues.apache.org/jira/browse/HIVE-13966 > Project: Hive > Issue Type: Bug > Components: HCatalog > Reporter: Nachiket Vaidya > Assignee: Mohit Sabharwal > Priority: Critical > Labels: TODOC2.2 > Fix For: 2.2.0 > > Attachments: HIVE-13966.1.patch, HIVE-13966.2.patch, > HIVE-13966.3.patch, HIVE-13966.4.patch, HIVE-13966.4.patch, > HIVE-13966.5.patch, HIVE-13966.6.patch, HIVE-13966.pdf > > > The code for each API in HiveMetaStore.java is like this: > 1. openTransaction() > 2. -- operation-- > 3. commit() or rollback() based on result of the operation. > 4. add entry to notification log (unconditionally) > If the operation is failed (in step 2), we still add entry to notification > log. Found this issue in testing. > It is still ok as this is the case of false positive. > If the operation is successful and adding to notification log failed, the > user will get an MetaException. It will not rollback the operation, as it is > already committed. We need to handle this case so that we will not have false > negatives. -- This message was sent by Atlassian JIRA (v6.3.4#6332)