[ https://issues.apache.org/jira/browse/HIVE-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689971#comment-15689971 ]
Hive QA commented on HIVE-15257: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12839946/HIVE-15257.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10729 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=133) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[transform_ppr2] (batchId=133) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid] (batchId=150) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=145) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=91) org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver (batchId=226) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2260/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2260/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2260/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12839946 - PreCommit-HIVE-Build > remove useless cleanupReaders in OrcEncodedDataReader > ----------------------------------------------------- > > Key: HIVE-15257 > URL: https://issues.apache.org/jira/browse/HIVE-15257 > Project: Hive > Issue Type: Bug > Components: llap > Affects Versions: 2.1.0, 2.2.0 > Reporter: Fei Hui > Assignee: Fei Hui > Attachments: HIVE-15257.1.patch > > > it has cleanupReaders() in processStop() > cleanupReaders is useless in if(processStop()){} block -- This message was sent by Atlassian JIRA (v6.3.4#6332)