[ 
https://issues.apache.org/jira/browse/HIVE-15273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692910#comment-15692910
 ] 

Lefty Leverenz commented on HIVE-15273:
---------------------------------------

Review of configuration parameters:  Please make the parameter descriptions 
more formal.

For example, for *hive.druid.http.numConnection* you could change "num 
connection used by the http client" to "Number of connections used by the HTTP 
client."  For *hive.druid.http.read.timeout* you could change "read timeout 
period for the http client" to something like "Read timeout period for the HTTP 
client, in <units>."

Also, what does "PT1M" mean (as the default for 
*hive.druid.http.read.timeout*)?  Usually a time interval is specified with a 
TimeValidator, for example:

{code}
      HIVES_AUTO_PROGRESS_TIMEOUT("hive.auto.progress.timeout", "0s",
        new TimeValidator(TimeUnit.SECONDS),
{code}

> Http Client not configured correctly
> ------------------------------------
>
>                 Key: HIVE-15273
>                 URL: https://issues.apache.org/jira/browse/HIVE-15273
>             Project: Hive
>          Issue Type: Bug
>          Components: Druid integration
>            Reporter: slim bouguerra
>            Assignee: slim bouguerra
>            Priority: Minor
>         Attachments: 0001-adding-confing-to-http-client.patch
>
>
> Current used http client by the druid-hive record reader is constructed with 
> default values. Default values of numConnection and ReadTimeout are very 
> small which can lead to following exception " ERROR 
> [2ee34a2b-c8a5-4748-ab91-db3621d2aa5c main] CliDriver: Failed with exception 
> java.io.IOException:java.io.IOException: java.io.IOException: org.apache.h
> ive.druid.org.jboss.netty.channel.ChannelException: Channel disconnected"
> Full stack can be found 
> here.https://gist.github.com/b-slim/384ca6a96698f5b51ad9b171cff556a2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to