Gunther Hagleitner commented on HIVE-15323:

LGTM +1. Couple of comments though (since you're resurrecting code, probably 
fine): a) There are some checks for whether optraits are null. Other places 
don't, not sure that's just an oversight. b) If the group by's parent doesn't 
have an optraits object we init the # reduce sinks to 0. That means it will 
pass the new check, but likely shouldn't...

> allow the user to turn off reduce-side SMB  join
> ------------------------------------------------
>                 Key: HIVE-15323
>                 URL: https://issues.apache.org/jira/browse/HIVE-15323
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-15323.patch

This message was sent by Atlassian JIRA

Reply via email to