[
https://issues.apache.org/jira/browse/HIVE-15332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723300#comment-15723300
]
Vaibhav Gumashta commented on HIVE-15332:
-----------------------------------------
+1, but some minor comments below (can be taken up in new jiras):
bq. 206 batchSize = 15;
Make this default batch size configurable?
bq. 515 analyzeTableLoad(dbNameOrPattern, tblNameOrPattern,
dir.getPath().toUri().toString(), null);
Did you intend to implement this as part of analyzeEventLoad?
General comment: should we have an replRoot/events/evId1 etc type of directory
hierarchy to make it easy to filter?
Also, creating follow up jiras for:
# Enhancing DBNotif listener to capture files added (if any) on create
table/partition events (line 273 FIXME)
# Implementing consolidateEvent (bootstrap rubberbanding)
# Add new methods to MessageFactory API (corresponding to JSONMessageFactory)
> REPL LOAD & DUMP support for incremental CREATE_TABLE/ADD_PTN
> -------------------------------------------------------------
>
> Key: HIVE-15332
> URL: https://issues.apache.org/jira/browse/HIVE-15332
> Project: Hive
> Issue Type: Sub-task
> Components: repl
> Reporter: Sushanth Sowmyan
> Assignee: Sushanth Sowmyan
> Attachments: HIVE-15332.patch
>
>
> We need to add in support for REPL LOAD and REPL DUMP of incremental events,
> and we need to be able to replicate creates, for a start. This jira tracks
> the inclusion of CREATE_TABLE/ADD_PARTITION event support to REPL DUMP & LOAD.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
