[
https://issues.apache.org/jira/browse/HIVE-15359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15729820#comment-15729820
]
Aihua Xu commented on HIVE-15359:
---------------------------------
The patch looks good.
It would be good if we can add some comments to
{noformat}
if (preReader != null && preReader instanceof CombineHiveRecordReader
73 && ((CombineHiveRecordReader)preReader).getFooterBuffer() !=
null) {
74 if (partition != 0 && hsplit.getPaths()[partition
-1].equals(hsplit.getPaths()[partition])) //the split is from same file as
previous split.
75
this.setFooterBuffer(((CombineHiveRecordReader)preReader).getFooterBuffer());
{noformat}
+1.
> skip.footer.line.count doesnt work properly for certain situations
> ------------------------------------------------------------------
>
> Key: HIVE-15359
> URL: https://issues.apache.org/jira/browse/HIVE-15359
> Project: Hive
> Issue Type: Bug
> Components: Reader
> Reporter: Yongzhi Chen
> Assignee: Yongzhi Chen
> Attachments: HIVE-15359.1.patch
>
>
> This issue's reproduce is very like HIVE-12718 , but the data file is larger
> than 128M . In this case, even make sure only one mapper is used, the footer
> is still wrongly skipped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
