[ 
https://issues.apache.org/jira/browse/HIVE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aihua Xu updated HIVE-15518:
----------------------------
    Description: 
{noformat}
  /*
   * - A Window Frame that has only the /start/boundary, then it is interpreted 
as:
         BETWEEN <start boundary> AND CURRENT ROW
   * - A Window Specification with an Order Specification and no Window
   *   Frame is interpreted as:
         ROW BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
   * - A Window Specification with no Order and no Window Frame is interpreted 
as:
         ROW BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
   */
{noformat}

The comments in WindowSpec above doesn't really match what it's claimed to do. 
Correct the comment to reduce the confusion.

Also currently the window type is specified on each BoundarySpec but makes 
sense to put the type (rows or range) for each window.

  was:
{noformat}
  /*
   * - A Window Frame that has only the /start/boundary, then it is interpreted 
as:
         BETWEEN <start boundary> AND CURRENT ROW
   * - A Window Specification with an Order Specification and no Window
   *   Frame is interpreted as:
         ROW BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
   * - A Window Specification with no Order and no Window Frame is interpreted 
as:
         ROW BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
   */
{noformat}

The comments in WindowSpec above doesn't really match what it's claimed to do. 
Correct the comment to reduce the confusion.


> Refactoring rows and range related classes to put the window type on 
> WindowFrame
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-15518
>                 URL: https://issues.apache.org/jira/browse/HIVE-15518
>             Project: Hive
>          Issue Type: Bug
>          Components: PTF-Windowing
>            Reporter: Aihua Xu
>            Assignee: Aihua Xu
>            Priority: Trivial
>
> {noformat}
>   /*
>    * - A Window Frame that has only the /start/boundary, then it is 
> interpreted as:
>          BETWEEN <start boundary> AND CURRENT ROW
>    * - A Window Specification with an Order Specification and no Window
>    *   Frame is interpreted as:
>          ROW BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW
>    * - A Window Specification with no Order and no Window Frame is 
> interpreted as:
>          ROW BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING
>    */
> {noformat}
> The comments in WindowSpec above doesn't really match what it's claimed to 
> do. Correct the comment to reduce the confusion.
> Also currently the window type is specified on each BoundarySpec but makes 
> sense to put the type (rows or range) for each window.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to