[ 
https://issues.apache.org/jira/browse/HIVE-15564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816066#comment-15816066
 ] 

zhihai xu commented on HIVE-15564:
----------------------------------

Thanks for the review! Nice finding, the job id is set in the final block, but 
It would be better to move it right after {{rj = jc.submitJob(job);}}, so we 
don't need to wait for the job completed to get the job id and it will be 
useful to monitor the job in hook. I attached a new patch which move the job id 
setting from the final block to right-after submitJob. Please review!

> set task's jobID with hadoop map reduce job ID for PartialScanTask, 
> MergeFileTask and ColumnTruncateTask.
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-15564
>                 URL: https://issues.apache.org/jira/browse/HIVE-15564
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: HIVE-15564.000.patch
>
>
> set task's jobID with hadoop map reduce job ID for PartialScanTask, 
> MergeFileTask and ColumnTruncateTask. Since ExecDriver already set task's 
> jobID with hadoop map reduce job ID, this patch will make it consistent for 
> all tasks who submit map reduce job.
> {code}
>       // Finally SUBMIT the JOB!
>       rj = jc.submitJob(job);
>       this.jobID = rj.getJobID();
>       updateStatusInQueryDisplay();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to