[
https://issues.apache.org/jira/browse/HIVE-15166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826111#comment-15826111
]
Aihua Xu commented on HIVE-15166:
---------------------------------
The change looks good. Of course, I left a comment that jLine FileHistory
constructor needs an improvement to take the max_size, since otherwise, it will
load 500 lines and then resize to the specified number of lines. The load could
potentially cause OOM, but with current jLine, it's hard to change that.
+1 pending test.
> Provide beeline option to set the jline history max size
> --------------------------------------------------------
>
> Key: HIVE-15166
> URL: https://issues.apache.org/jira/browse/HIVE-15166
> Project: Hive
> Issue Type: Improvement
> Components: Beeline
> Affects Versions: 2.1.0
> Reporter: Eric Lin
> Assignee: Eric Lin
> Priority: Minor
> Attachments: HIVE-15166.2.patch, HIVE-15166.patch
>
>
> Currently Beeline does not provide an option to limit the max size for
> beeline history file, in the case that each query is very big, it will flood
> the history file and slow down beeline on start up and shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
