[
https://issues.apache.org/jira/browse/HIVE-15741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15844109#comment-15844109
]
Hive QA commented on HIVE-15741:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12849817/HIVE-15741.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 11003 tests
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out)
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=140)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
(batchId=93)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3243/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3243/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3243/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12849817 - PreCommit-HIVE-Build
> Faster unsafe byte array comparisons
> ------------------------------------
>
> Key: HIVE-15741
> URL: https://issues.apache.org/jira/browse/HIVE-15741
> Project: Hive
> Issue Type: Improvement
> Reporter: Teddy Choi
> Assignee: Teddy Choi
> Priority: Minor
> Attachments: HIVE-15741.1.patch, HIVE-15741.2.patch,
> HIVE-15741.3.patch
>
>
> Byte array comparison is heavily used in joins and string conditions. Pure
> Java implementation is simple but not performant. An implementation with
> Unsafe#getLong is much faster. It's already implemented in
> org.apache.hadoop.io.WritableComparator#compare. The WritableComparator class
> handles exceptional cases, including a different endian and no access to
> Unsafe, and it was used for many years in production.
> This patch will replace pure Java byte array comparisons with safe and faster
> unsafe ones to get more performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
