[ 
https://issues.apache.org/jira/browse/HIVE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856845#comment-15856845
 ] 

Hive QA commented on HIVE-10562:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12851458/HIVE-10562.4.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10198 tests 
executed
*Failed tests:*
{noformat}
TestCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=2)
        
[ppd_constant_where.q,drop_index_removes_partition_dirs.q,cbo_input26.q,unionall_unbalancedppd.q,varchar_serde.q,bucket_map_join_spark2.q,select_unquote_and.q,cte_mat_5.q,udf_next_day.q,input28.q,udf_hour.q,avro_timestamp_win.q,showparts.q,udf_date_sub.q,cbo_udf_max.q,input43.q,uber_reduce.q,nullgroup3.q,schema_evol_orc_nonvec_part_all_complex.q,temp_table_options1.q,union21.q,authorization_role_grant1.q,mergejoins.q,show_create_database.q,smb_mapjoin_11.q,udf_crc32.q,materialized_view_create_rewrite.q,merge2.q,join_nulls.q,multi_join_union.q]
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=235)
TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=117)
        
[join39.q,bucketsortoptimize_insert_7.q,vector_distinct_2.q,bucketmapjoin10.q,join11.q,union13.q,auto_sortmerge_join_16.q,windowing.q,union_remove_3.q,skewjoinopt7.q,stats7.q,annotate_stats_join.q,multi_insert_lateral_view.q,ptf_streaming.q,join_1to1.q]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[index_auto_mult_tables] 
(batchId=78)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
 (batchId=159)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=223)
org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade (batchId=211)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3420/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3420/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3420/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12851458 - PreCommit-HIVE-Build

> Add version column to NOTIFICATION_LOG table and DbNotificationListener
> -----------------------------------------------------------------------
>
>                 Key: HIVE-10562
>                 URL: https://issues.apache.org/jira/browse/HIVE-10562
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Import/Export
>    Affects Versions: 1.2.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>         Attachments: HIVE-10562.2.patch, HIVE-10562.3.patch, 
> HIVE-10562.4.patch, HIVE-10562.patch
>
>
> Currently, we have a JSON encoded message being stored in the 
> NOTIFICATION_LOG table.
> If we want to be future proof, we need to allow for versioning of this 
> message, since we might change what gets stored in the message. A prime 
> example of what we'd want to change is as in HIVE-10393.
> MessageFactory already has stubs to allow for versioning of messages, and we 
> could expand on this further in the future. NotificationListener currently 
> encodes the message version into the header for the JMS message it sends, 
> which seems to be the right place for a message version (instead of being 
> contained in the message, for eg.).
> So, we should have a similar ability for DbEventListener as well, and the 
> place this makes the most sense is to and add a version column to the 
> NOTIFICATION_LOG table.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to