[
https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864842#comment-15864842
]
Thejas M Nair commented on HIVE-15473:
--------------------------------------
[~anishek]
It seems like the thrift file wasn't regenerated after the version change -
{code}
34134[hive17:07]$ git grep HIVE_CLI_SERVICE_PROTOCOL_V10
service-rpc/if/TCLIService.thrift: HIVE_CLI_SERVICE_PROTOCOL_V10
service-rpc/if/TCLIService.thrift: 1: required TProtocolVersion
client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
service-rpc/if/TCLIService.thrift: 2: required TProtocolVersion
serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
134134[hive17:27]$
134134[hive17:27]$
134134[hive17:27]$ git grep HIVE_CLI_SERVICE_PROTOCOL_V9
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9);
service-rpc/if/TCLIService.thrift: HIVE_CLI_SERVICE_PROTOCOL_V9
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp:
TProtocolVersion::HIVE_CLI_SERVICE_PROTOCOL_V9
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp:
"HIVE_CLI_SERVICE_PROTOCOL_V9"
service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h:
HIVE_CLI_SERVICE_PROTOCOL_V9 = 8
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java:
this.client_protocol =
org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9;
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java:
this.client_protocol =
org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9;
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java:
this.serverProtocolVersion =
org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9;
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java:
this.serverProtocolVersion =
org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9;
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java:
HIVE_CLI_SERVICE_PROTOCOL_V9(8);
service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java:
return HIVE_CLI_SERVICE_PROTOCOL_V9;
service-rpc/src/gen/thrift/gen-php/Types.php: const
HIVE_CLI_SERVICE_PROTOCOL_V9 = 8;
service-rpc/src/gen/thrift/gen-php/Types.php: 8 =>
'HIVE_CLI_SERVICE_PROTOCOL_V9',
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py:
HIVE_CLI_SERVICE_PROTOCOL_V9 = 8
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py: 8:
"HIVE_CLI_SERVICE_PROTOCOL_V9",
service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py:
"HIVE_CLI_SERVICE_PROTOCOL_V9": 8,
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb:
HIVE_CLI_SERVICE_PROTOCOL_V9 = 8
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: VALUE_MAP = {0 =>
"HIVE_CLI_SERVICE_PROTOCOL_V1", 1 => "HIVE_CLI_SERVICE_PROTOCOL_V2", 2 =>
"HIVE_CLI_SERVICE_PROTOCOL_V3", 3 => "HIVE_CLI_SERVICE_PROTOCOL_V4", 4 =>
"HIVE_CLI_SERVICE_PROTOCOL_V5", 5 => "HIVE_CLI_SERVICE_PROTOCOL_V6", 6 =>
"HIVE_CLI_SERVICE_PROTOCOL_V7", 7 => "HIVE_CLI_SERVICE_PROTOCOL_V8", 8 =>
"HIVE_CLI_SERVICE_PROTOCOL_V9"}
service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: VALID_VALUES =
Set.new([HIVE_CLI_SERVICE_PROTOCOL_V1, HIVE_CLI_SERVICE_PROTOCOL_V2,
HIVE_CLI_SERVICE_PROTOCOL_V3, HIVE_CLI_SERVICE_PROTOCOL_V4,
HIVE_CLI_SERVICE_PROTOCOL_V5, HIVE_CLI_SERVICE_PROTOCOL_V6,
HIVE_CLI_SERVICE_PROTOCOL_V7, HIVE_CLI_SERVICE_PROTOCOL_V8,
HIVE_CLI_SERVICE_PROTOCOL_V9]).freeze
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user",
"passw", "127.0.0.1",
{code}
> Progress Bar on Beeline client
> ------------------------------
>
> Key: HIVE-15473
> URL: https://issues.apache.org/jira/browse/HIVE-15473
> Project: Hive
> Issue Type: Improvement
> Components: Beeline, HiveServer2
> Affects Versions: 2.1.1
> Reporter: anishek
> Assignee: anishek
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-15473.10.patch, HIVE-15473.11.patch,
> HIVE-15473.2.patch, HIVE-15473.3.patch, HIVE-15473.4.patch,
> HIVE-15473.5.patch, HIVE-15473.6.patch, HIVE-15473.7.patch,
> HIVE-15473.8.patch, HIVE-15473.9.patch, io_summary_after_patch.png,
> io_summary_before_patch.png, screen_shot_beeline.jpg, status_after_patch.png,
> status_before_patch.png, summary_after_patch.png, summary_before_patch.png
>
>
> Hive Cli allows showing progress bar for tez execution engine as shown in
> https://issues.apache.org/jira/secure/attachment/12678767/ux-demo.gif
> it would be great to have similar progress bar displayed when user is
> connecting via beeline command line client as well.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
