[ 
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870399#comment-15870399
 ] 

Thejas M Nair commented on HIVE-15910:
--------------------------------------

In addition, I think we should look at the methods called in CompactorTest 
constructor.
CompactorTest constructor would be called for every test function. Ie it is 
equivalent of '@Before' and not '@BeforeClass' .
It seems like some what is done there makes more sense in a '@BeforeClass' , so 
that its just done once. But I haven't taken a very close look at the tests, so 
I am not sure. Maybe this should be addressed in a follow up jira, and not this 
one. 

cc [~ekoifman] [~wzheng] [~alangates]
{code}
    ms = new HiveMetaStoreClient(conf);
    txnHandler = TxnUtils.getTxnStore(conf);
    tmpdir = new File(System.getProperty("java.io.tmpdir") +
        System.getProperty("file.separator") + "compactor_test_tables");
    tmpdir.mkdir();
    tmpdir.deleteOnExit();
{code}

> Improvements in Hive Unit Test by using In-memory Derby DB
> ----------------------------------------------------------
>
>                 Key: HIVE-15910
>                 URL: https://issues.apache.org/jira/browse/HIVE-15910
>             Project: Hive
>          Issue Type: Test
>          Components: Tests
>            Reporter: Sankar Hariappan
>            Assignee: Wei Zheng
>         Attachments: HIVE-15910.01.patch, HIVE-15910.05.patch, 
> HIVE-15910.2.patch, HIVE-15910.3.patch, HIVE-15910.4.patch
>
>
> Hive UT currently uses Derby DB with storage on disk which have some 
> practical problems.
> 1. The run-time of Hive unit tests are high as need to operate on the disk 
> quite often.
> 2. It can cause conflict if multiple test cases operates on the same table 
> name (such as table being created already exist).
> To solve these problems, we shall use an in-memory storage option of Derby DB 
> which can be even persisted if the test case demands that.
> https://db.apache.org/derby/docs/10.8/devguide/cdevdvlpinmemdb.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to