[
https://issues.apache.org/jira/browse/HIVE-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Barna Zsombor Klara updated HIVE-16024:
---------------------------------------
Attachment: HIVE-16024.02.patch
Thanks for taking a look at the patch [~vihangk1].
The hive.strict.checks.large.query is driven by the setting of
hive.mapred.mode. If the mapred mode is not strict then the strict checks are
not performed. So we could say that both are causing the exception.
I have added the performance logging, you are right that this should be
wrapping the metastore call.
I don't think however that the change in the thrown exception type is relevant.
The original code before this regression was also throwing HiveException, we
did not have a release with the SemanticException version and I don't see a
benefit in wrapping the HiveException since I cannot provide any useful,
context related information.
I am tempted a bit to make PartitionPruner#getAllPartitions public and to reuse
that to reduce the code duplication, but I don't want to expose an API in the
pruner that isn't pruning... what do you think?
> MSCK Repair Requires nonstrict hive.mapred.mode
> -----------------------------------------------
>
> Key: HIVE-16024
> URL: https://issues.apache.org/jira/browse/HIVE-16024
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 2.2.0
> Reporter: Barna Zsombor Klara
> Assignee: Barna Zsombor Klara
> Attachments: HIVE-16024.01.patch, HIVE-16024.02.patch
>
>
> MSCK repair fails when hive.mapred.mode is set to strict
> HIVE-13788 modified the way we read up partitions for a table to improve
> performance. Unfortunately it is using PartitionPruner to load the partitions
> which in turn is checking hive.mapred.mode.
> The previous code did not check hive.mapred.mode.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
