[ 
https://issues.apache.org/jira/browse/HIVE-14459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Vary updated HIVE-14459:
------------------------------
    Attachment: HIVE-14459.5.patch

Addressed [~vihangk1]'s comments.

To use MiniHS2 in CoreBeeLineDriver I had to move it from hive-it-unit 
(itest/hive-unit) package to hive-it-util (itest/util) package.
I am not absolutely conformable with it, but I have thought about several 
different approach and this one is causing the less change in hive and feels 
the most natural. My problem with it is, that it might affect other projects 
which are using MiniHS2 in their test framework. 
What is your opinion about this change [~vihangk1], [~kgyrtkirk]? Anybody else 
to ask?

> TestBeeLineDriver - migration and re-enable
> -------------------------------------------
>
>                 Key: HIVE-14459
>                 URL: https://issues.apache.org/jira/browse/HIVE-14459
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Zoltan Haindrich
>            Assignee: Peter Vary
>         Attachments: HIVE-14459.2.patch, HIVE-14459.3.patch, 
> HIVE-14459.4.patch, HIVE-14459.5.patch, HIVE-14459.patch
>
>
> this test have been left behind in HIVE-14444 because it had some compile 
> issues.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to