[
https://issues.apache.org/jira/browse/HIVE-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884352#comment-15884352
]
Vaibhav Gumashta commented on HIVE-15305:
-----------------------------------------
Thanks for the patch [~mohitsabharwal].
Minor nits:
1. The comment for the abstract class needs to be adjusted.
2. You can avoid the if/else checks for transactional in
TestDbNotificationListener by having the transactional logic in
TestTransactionalDbNotificationListener and delegating to parent class for the
rest.
Other than that, I'm +1.
> Add tests for METASTORE_EVENT_LISTENERS
> ---------------------------------------
>
> Key: HIVE-15305
> URL: https://issues.apache.org/jira/browse/HIVE-15305
> Project: Hive
> Issue Type: Bug
> Reporter: Mohit Sabharwal
> Assignee: Mohit Sabharwal
> Attachments: HIVE-15305.patch
>
>
> HIVE-15232 reused TestDbNotificationListener to test
> METASTORE_TRANSACTIONAL_EVENT_LISTENERS and removed unit testing of
> METASTORE_EVENT_LISTENERS config. We should test both.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
