[ 
https://issues.apache.org/jira/browse/HIVE-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891113#comment-15891113
 ] 

Sankar Hariappan edited comment on HIVE-16006 at 3/1/17 9:45 PM:
-----------------------------------------------------------------

[~sushanth] [~thejas]

Yes, the test case was not running as it was marked as @Ignore. That's why it 
reported as no failures when you test on the base code.
When I enabled the test case and ran, it had other failures unrelated to my 
fix. 
1. The test was not ran with the FIRE_EVENTS_FOR_DML configuration set as true.
2. When invoke incremental dump on a DB other than the current session's DB, it 
fails for insert event dump.

The patch-03 have the fix for all these and all tests passed locally.
Please review it.


was (Author: sankarh):
[~sushanth] [~thejas]

Yes, the test case was not running as it was marked as @Ignore.
When I ran the test, it had other failures unrelated to my fix. 
1. The test was not ran with the FIRE_EVENTS_FOR_DML configuration set as true.
2. When invoke incremental dump on a DB other than the current session's DB, it 
fails for insert event dump.

The patch-03 have the fix for all these and all tests passed locally.
Please review it.

> Incremental REPL LOAD Inserts doesn't operate on the target database if name 
> differs from source database.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-16006
>                 URL: https://issues.apache.org/jira/browse/HIVE-16006
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl
>            Reporter: Sankar Hariappan
>            Assignee: Sankar Hariappan
>         Attachments: HIVE-16006.01.patch, HIVE-16006.02.patch, 
> HIVE-16006.03.patch
>
>
> During "Incremental Load", it is not considering the database name input in 
> the command line. Hence load doesn't happen. At the same time, database with 
> original name is getting modified.
> Steps:
> 1. INSERT INTO default.tbl values (10, 20);
> 2. REPL DUMP default FROM 52;
> 3. REPL LOAD replDb FROM '/tmp/dump/1487588522621';
> – This step modifies the default Db instead of replDb.
> ==
> Additional note - this is happening for INSERT events, not other events.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to