[
https://issues.apache.org/jira/browse/HIVE-16119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897749#comment-15897749
]
Vihang Karajgaonkar commented on HIVE-16119:
--------------------------------------------
Thanks for the patch [~kgyrtkirk]. Always, a good idea to remove redundant
code. Just one comment from my side. The conditional check {{poolSize =
poolSize == 0 ? poolSize : Math.max(poolSize, getMinPoolSize());}} is not
needed since it is executing in the else block. We could just replace it with
{{poolSize = Math.max(poolSize, getMinPoolSize());}}
> HiveMetaStoreChecker - singleThread/parallel logic duplication
> --------------------------------------------------------------
>
> Key: HIVE-16119
> URL: https://issues.apache.org/jira/browse/HIVE-16119
> Project: Hive
> Issue Type: Improvement
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Minor
> Attachments: HIVE-16119.1.patch
>
>
> It looks to me that the main logic is duplicated, because of multithereading
> support:
> * {{HiveMetaStoreChecker#PathDepthInfoCallable#processPathDepthInfo}}
> * {{HiveMetaStoreChecker#checkPartitionDirsSingleThreaded}}
> It might be possible to remove the singleThreaded methods by using a special
> executor for single thread support: {{MoreExecutors.sameThreadExecutor()}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
