[
https://issues.apache.org/jira/browse/HIVE-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901833#comment-15901833
]
Siddharth Seth commented on HIVE-16104:
---------------------------------------
bq. The lock in trySchedule is unnecessary so I removed it and renamed the
method;
Not required, or relevant to this patch.
bq. preemption was surrounded by a loop because previously, if the first task
in queue was finishable it would bail without preempting anything even if there
are more tasks.
I believe this is mostly harmless - the same task will be picked up in the next
loop. Unrelated to the jira, but probably a relevant change.There's some change
around switching the condition to return early (negative condition - return,
instead of the existing conditions met-> execute) - which is unnecessary.
Similar condition changes elsewhere as well.
bq. I can merge updateQueueMetric back into being copy-pasted in 3 places...
also one if was refactored because it has lots of repetitive code.
bq. Another method was added because something that was previously called in
one place is now called in 2 places and I didn't want to copy-paste it.
These would be relevant to the jira? - since additional invocations are
happening because of the change.
> LLAP: preemption may be too aggressive if the pre-empted task doesn't die
> immediately
> -------------------------------------------------------------------------------------
>
> Key: HIVE-16104
> URL: https://issues.apache.org/jira/browse/HIVE-16104
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-16104.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
