[
https://issues.apache.org/jira/browse/HIVE-16163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923552#comment-15923552
]
Hive QA commented on HIVE-16163:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12858592/HIVE-16163.01.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 10343 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4116/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4116/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4116/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12858592 - PreCommit-HIVE-Build
> Remove unnecessary parentheses in HiveParser
> --------------------------------------------
>
> Key: HIVE-16163
> URL: https://issues.apache.org/jira/browse/HIVE-16163
> Project: Hive
> Issue Type: Bug
> Reporter: Pengcheng Xiong
> Assignee: Pengcheng Xiong
> Attachments: HIVE-16163.01.patch
>
>
> in HiveParser.g
> L2145:
> {code}
> columnParenthesesList
> @init { pushMsg("column parentheses list", state); }
> @after { popMsg(state); }
> : LPAREN columnNameList RPAREN
> ;
> {code}
> should be changed to
> {code}
> columnParenthesesList
> @init { pushMsg("column parentheses list", state); }
> @after { popMsg(state); }
> : LPAREN! columnNameList RPAREN!
> ;
> {code}
> However, we also need to refactor our code.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
