[
https://issues.apache.org/jira/browse/HIVE-16191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925369#comment-15925369
]
Sergey Shelukhin commented on HIVE-16191:
-----------------------------------------
Yeah, so it's 3 useless objects (also the future); plus it uses an existing
executor for the callback. That's not the LOC I had in mind - that's just
object cruft.
One way to cut on lines would be to remove the entire callback class and
replace it with a little-known java feature knowт as "a finally block" :)
What I meant was something like this
http://thedailywtf.com/articles/The-Enterprise-User-Agent ; the fact that it
"does the job" doesn't mean everything else is a style choice... Anyway, it
doesn't matter here.
> simplify thread usage in TaskExecutorService
> --------------------------------------------
>
> Key: HIVE-16191
> URL: https://issues.apache.org/jira/browse/HIVE-16191
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-16191.patch
>
>
> Remove executors, futures, decorators etc where not needed
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
