[ 
https://issues.apache.org/jira/browse/HIVE-13584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942007#comment-15942007
 ] 

Hive QA commented on HIVE-13584:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12817040/HIVE-13584.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10512 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
 (batchId=231)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[comments] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
 (batchId=141)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4371/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4371/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4371/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12817040 - PreCommit-HIVE-Build

> HBaseStorageHandler should support table pre-split
> --------------------------------------------------
>
>                 Key: HIVE-13584
>                 URL: https://issues.apache.org/jira/browse/HIVE-13584
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler
>    Affects Versions: 2.0.0
>            Reporter: Svetozar Ivanov
>            Assignee: Svetozar Ivanov
>              Labels: HBase, PreSplit
>         Attachments: HIVE-13584.1.patch, HIVE-13584.2.patch, 
> HIVE-13584.3.patch, HIVE-13584.4.patch, HIVE-13584-branch-2.0.patch, 
> HIVE-13584.patch
>
>
> Currently is not possible creation of HBase table via HBaseStorageHandler 
> with specified pre-split strategy.
> I use it in my code with applied patch in that way:
> {code}
> public String buildCreateTblStatement(TableDescriptor tableDescriptor) {
>         StringBuilder createTableStatement = ...;
>         ...
>         ...
>         String tblProperties = buildTblProperties(tableDescriptor);
>         if (StringUtils.isNotBlank(tblProperties)) {
>              createTableStatement.append(" TBLPROPERTIES (" + tblProperties + 
> ")");
>         }
>          ...
>         return createTableStatement.toString();
> }
> private static String buildTblProperties(TableDescriptor tableDescriptor) {
>         ...
>         ...
>         if (supportsPreSplit(tableDescriptor)) {
>             sb.append(", ");
>             sb.append(quoteInSingleQuotes(HBaseStorageHandler.SPLITS_NUMBER));
>             sb.append(" = ");
>             
> sb.append(quoteInSingleQuotes(String.valueOf(tableDescriptor.getNumRegions())));
>             GeneratedPKDescriptor columnDescriptor = (GeneratedPKDescriptor) 
> tableDescriptor.getPkDescriptors().get(0);
>             sb.append(", ");
>             
> sb.append(quoteInSingleQuotes(HBaseStorageHandler.SPLIT_ALGORITHM_FIRSTROW_KEY));
>             sb.append(" = ");
>             
> sb.append(quoteInSingleQuotes(columnDescriptor.getPkGenerator().firstRowKey()));
>             sb.append(", ");
>             
> sb.append(quoteInSingleQuotes(HBaseStorageHandler.SPLIT_ALGORITHM_LASTROW_KEY));
>             sb.append(" = ");
>             
> sb.append(quoteInSingleQuotes(columnDescriptor.getPkGenerator().lastRowKey()));
>         }
>         logger.trace("TBLPROPERTIES are [{}]", sb);
>         return sb.toString();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to