[ 
https://issues.apache.org/jira/browse/HIVE-15184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946979#comment-15946979
 ] 

Peter Vary commented on HIVE-15184:
-----------------------------------

[~sbeeram]: If the thread is stopped, then the TokeStore become a memory leak 
by accumulating the token objects forever. We will get an OOM error eventually, 
but after a longer period of time, and at that moment we will have very hard 
time to identify the original problem which caused this. That is why I think it 
is better for the long term, to exit immediately.
The {{JDODataStoreException}} is a subclass of {{JDOCanRetryException}}, so 
after this patch the MetaStore will try to recover.

> Add the possibility to separate recoverable and not recoverable errors in 
> DeletagionTokenStore
> ----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-15184
>                 URL: https://issues.apache.org/jira/browse/HIVE-15184
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2, Metastore
>    Affects Versions: 1.3.0, 2.0.1, 2.1.0, 2.2.0
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>         Attachments: HIVE-15184.patch
>
>
> After HIVE-15090 committed we discussed it with [~thejas] and agreed, that it 
> would be even better if the DelegateTokenStore implementation could decide if 
> an error is recoverable or not. Since the DelegationTokenStore is not 
> mentioned as a Hive API it is possible to change the interface, so we could 
> change the implementations shipped with Hive to use the new functionality, 
> and if someone uses it's own implementation of DelegationTokenStore, then he 
> should do the matching changes himself



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to