[
https://issues.apache.org/jira/browse/HIVE-16174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949886#comment-15949886
]
Ashutosh Chauhan commented on HIVE-16174:
-----------------------------------------
+1
> Update MetricsConstant.WAITING_COMPILE_OPS metric when we aquire lock failed
> in Driver
> --------------------------------------------------------------------------------------
>
> Key: HIVE-16174
> URL: https://issues.apache.org/jira/browse/HIVE-16174
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
> Affects Versions: 2.2.0
> Reporter: yunfei liu
> Assignee: yunfei liu
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: HIVE-16174.1.patch
>
>
> In Driver#compileInternal method (as the code snippet below ), we need to
> update MetricsConstant.WAITING_COMPILE_OPS metric correctly before return if
> lock can not be acquired.
> {code}
> Metrics metrics = MetricsFactory.getInstance();
> if (metrics != null) {
> metrics.incrementCounter(MetricsConstant.WAITING_COMPILE_OPS, 1);
> }
> final ReentrantLock compileLock = tryAcquireCompileLock(isParallelEnabled,
> command);
> if (compileLock == null) {
> return ErrorMsg.COMPILE_LOCK_TIMED_OUT.getErrorCode();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
