[
https://issues.apache.org/jira/browse/HIVE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955628#comment-15955628
]
Xuefu Zhang edited comment on HIVE-16311 at 4/4/17 6:58 PM:
------------------------------------------------------------
[~colin_mjj], The code changes looks good. However, I'm not sure how the test
diff (such as below) came:
{code}
-1234567.8901234560 137174.210013717333
+1234567.8901234560 137174.210013717330
{code}
was (Author: xuefuz):
[~colin_mjj], The code changes looks good. However, I'm not sure how the test
diff (such as below) came:
{code}
-1234567.8901234560 137174.210013717333
+1234567.8901234560 137174.210013717330
{code}
> Improve the performance for FastHiveDecimalImpl.fastDivide
> ----------------------------------------------------------
>
> Key: HIVE-16311
> URL: https://issues.apache.org/jira/browse/HIVE-16311
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Colin Ma
> Assignee: Colin Ma
> Fix For: 3.0.0
>
> Attachments: HIVE-16311.001.patch, HIVE-16311.002.patch,
> HIVE-16311.003.patch, HIVE-16311.004.patch
>
>
> FastHiveDecimalImpl.fastDivide is poor performance when evaluate the
> expression as 12345.67/123.45
> There are 2 points can be improved:
> 1. Don't always use HiveDecimal.MAX_SCALE as scale when do the
> BigDecimal.divide.
> 2. Get the precision for BigInteger in a fast way if possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
