[
https://issues.apache.org/jira/browse/HIVE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956389#comment-15956389
]
Hive QA commented on HIVE-16311:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12862005/HIVE-16311.withTrailingZero.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 163 failed/errored test(s), 10577 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
(batchId=234)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments]
(batchId=234)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_select]
(batchId=58)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avro_decimal]
(batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[avro_decimal_native]
(batchId=26)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cast_tinyint_to_double]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[char_pad_convert]
(batchId=6)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[compute_stats_decimal]
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_3] (batchId=25)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_precision2]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_precision]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_udf] (batchId=9)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[implicit_decimal]
(batchId=63)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[infer_const_type]
(batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_nonacid_from_acid]
(batchId=69)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[materialized_view_create_rewrite]
(batchId=2)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[materialized_view_create_rewrite_multi_db]
(batchId=63)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[materialized_view_describe]
(batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[metadata_only_queries]
(batchId=30)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_file_dump]
(batchId=53)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_decimal1]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf4] (batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_abs] (batchId=42)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_case] (batchId=32)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_coalesce]
(batchId=77)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_format_number]
(batchId=8)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_least] (batchId=74)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_nullif] (batchId=79)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_union] (batchId=10)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_when] (batchId=7)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union36] (batchId=82)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_aggregate_9]
(batchId=37)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_3]
(batchId=18)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_aggregate]
(batchId=17)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_expressions]
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_math_funcs]
(batchId=22)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_decimal_precision]
(batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_13]
(batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_8]
(batchId=44)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_div0]
(batchId=64)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=19)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[view_cast] (batchId=38)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_llap_counters]
(batchId=140)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic]
(batchId=137)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lineage3]
(batchId=149)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[metadata_only_queries]
(batchId=147)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_create]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_nonvec_part_all_complex]
(batchId=141)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_orc_vec_part_all_complex]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_nonvec_part_all_complex]
(batchId=154)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part_all_complex]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vecrow_part_all_complex]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[udaf_collect_set_2]
(batchId=153)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_aggregate_9]
(batchId=148)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_3]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_aggregate]
(batchId=143)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_expressions]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_math_funcs]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_precision]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_decimal_udf]
(batchId=158)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_13]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_8]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_short_regress]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[vectorization_div0]
(batchId=96)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[udf_trunc_error2]
(batchId=88)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[wrong_column_type]
(batchId=88)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query13]
(batchId=229)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query21]
(batchId=229)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query48]
(batchId=229)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query85]
(batchId=229)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[avro_decimal_native]
(batchId=109)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[metadata_only_queries]
(batchId=111)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_decimal_aggregate]
(batchId=105)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_13]
(batchId=118)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_div0]
(batchId=126)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorization_short_regress]
(batchId=117)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_math_funcs]
(batchId=106)
org.apache.hadoop.hive.common.type.TestDecimal128.testDoubleValue (batchId=243)
org.apache.hadoop.hive.common.type.TestDecimal128.testFloatValue (batchId=243)
org.apache.hadoop.hive.common.type.TestDecimal128.testPiArcsine (batchId=243)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testBinaryConversion
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testCreateFromStringExponentSpecial
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testCreateFromStringPaddedSpecial
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testCreateFromStringSpecial
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testDecimalsWithKv7Keys
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testDecimalsWithKv7KeysWritable
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testDecimalsWithOneOne
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testDecimalsWithOneOneWritable
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testHashCode (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testMinus (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testPlus (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testPrecisionScaleEnforcement
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testRandomCreateFromString
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testRandomCreateFromStringExponent
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testRandomCreateFromStringPadded
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testRandomSetFromDouble
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testSetFromDoubleSpecial
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testSingleWordDivision
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testSort (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testSortRandom (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testSortSpecial (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testSubtract (batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimal.testTrailingZeroRemovalAfterEnforcement
(batchId=173)
org.apache.hadoop.hive.common.type.TestHiveDecimalOrcSerializationUtils.testSerializationUtilsWriteRead
(batchId=243)
org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorLazyBinaryDeserializeRow
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.TestVectorSerDeRow.testVectorLazySimpleDeserializeRow
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestDecimalUtil.testCeiling
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestDecimalUtil.testFloor
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestDecimalUtil.testNegate
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestDecimalUtil.testRound
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestDecimalUtil.testRoundWithDigits
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestDecimalUtil.testSign
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColAddDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColAddDecimalScalar
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColModuloDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColModuloDecimalScalar
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColMultiplyDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColMultiplyDecimalScalar
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColSubtractDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalColSubtractDecimalScalar
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalScalarAddDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalScalarModuloDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalScalarMultiplyDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorArithmeticExpressions.testDecimalScalarSubtractDecimalColumn
(batchId=267)
org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTypeCasts.testCastDecimalToString
(batchId=266)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testBigIntRowsClippedExact
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testBigIntRowsExact
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testIntRowsClippedExact
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testIntRowsExact
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRows2
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRows3
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsClipped1
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsClipped2
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsClippedExact1
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsClippedExact2
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsClippedExact3
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsExact1
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsExact2
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testMultiKeyRowsExact3
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testStringRowsClippedExact
(batchId=268)
org.apache.hadoop.hive.ql.exec.vector.mapjoin.fast.TestVectorMapJoinFastRowHashMap.testStringRowsExact
(batchId=268)
org.apache.hadoop.hive.ql.io.orc.TestOrcFile.testHiveDecimalIsNullReset[0]
(batchId=256)
org.apache.hadoop.hive.ql.io.orc.TestOrcFile.testHiveDecimalIsNullReset[1]
(batchId=256)
org.apache.hadoop.hive.ql.io.sarg.TestSearchArgumentImpl.testBuilderComplexTypes
(batchId=253)
org.apache.hadoop.hive.ql.io.sarg.TestSearchArgumentImpl.testBuilderComplexTypes2
(batchId=253)
org.apache.hadoop.hive.ql.udf.generic.TestGenericUDFOPDivide.testLongDivideDecimal
(batchId=245)
org.apache.hadoop.hive.serde2.binarysortable.TestBinarySortableFast.testBinarySortableFast
(batchId=281)
org.apache.hadoop.hive.serde2.binarysortable.TestBinarySortableSerDe.testBinarySortableSerDe
(batchId=281)
org.apache.hadoop.hive.serde2.lazy.TestLazySimpleFast.testLazySimpleFast
(batchId=281)
org.apache.hadoop.hive.serde2.lazybinary.TestLazyBinaryFast.testLazyBinaryFast
(batchId=282)
org.apache.hadoop.hive.serde2.lazybinary.TestLazyBinarySerDe.testLazyBinarySerDe
(batchId=282)
org.apache.hive.hcatalog.pig.TestRCFileHCatStorer.testDateCharTypes
(batchId=177)
org.apache.hive.hcatalog.pig.TestRCFileHCatStorer.testWriteDecimalXY
(batchId=177)
org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testDateCharTypes
(batchId=177)
org.apache.hive.hcatalog.pig.TestSequenceFileHCatStorer.testWriteDecimalXY
(batchId=177)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testDateCharTypes
(batchId=177)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDecimalXY
(batchId=177)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=220)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4558/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4558/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4558/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 163 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12862005 - PreCommit-HIVE-Build
> Improve the performance for FastHiveDecimalImpl.fastDivide
> ----------------------------------------------------------
>
> Key: HIVE-16311
> URL: https://issues.apache.org/jira/browse/HIVE-16311
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Colin Ma
> Assignee: Colin Ma
> Fix For: 3.0.0
>
> Attachments: HIVE-16311.001.patch, HIVE-16311.002.patch,
> HIVE-16311.003.patch, HIVE-16311.004.patch, HIVE-16311.withTrailingZero.patch
>
>
> FastHiveDecimalImpl.fastDivide is poor performance when evaluate the
> expression as 12345.67/123.45
> There are 2 points can be improved:
> 1. Don't always use HiveDecimal.MAX_SCALE as scale when do the
> BigDecimal.divide.
> 2. Get the precision for BigInteger in a fast way if possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
