[ 
https://issues.apache.org/jira/browse/HIVE-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958065#comment-15958065
 ] 

Hive QA commented on HIVE-16385:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12862163/HIVE-16385.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10577 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[drop_with_concurrency]
 (batchId=234)
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[escape_comments] 
(batchId=234)
org.apache.hive.jdbc.TestJdbcDriver2.testResultSetMetaData (batchId=220)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4567/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4567/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4567/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12862163 - PreCommit-HIVE-Build

> StatsNoJobTask could exit early before all partitions have been processed
> -------------------------------------------------------------------------
>
>                 Key: HIVE-16385
>                 URL: https://issues.apache.org/jira/browse/HIVE-16385
>             Project: Hive
>          Issue Type: Bug
>          Components: Statistics
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>         Attachments: HIVE-16385.1.patch
>
>
> For a partitioned table, the class {{StatsNoJobTask}} is supposed to launch 
> threads for all partitions and compute their stats. However, it could exit 
> early after at most 100 seconds:
> {code}
>   private void shutdownAndAwaitTermination(ExecutorService threadPool) {
>     // Disable new tasks from being submitted
>     threadPool.shutdown();
>     try {
>       // Wait a while for existing tasks to terminate
>       if (!threadPool.awaitTermination(100, TimeUnit.SECONDS)) {
>         // Cancel currently executing tasks
>         threadPool.shutdownNow();
>         // Wait a while for tasks to respond to being cancelled
>         if (!threadPool.awaitTermination(100, TimeUnit.SECONDS)) {
>           LOG.debug("Stats collection thread pool did not terminate");
>         }
>       }
>     } catch (InterruptedException ie) {
>       // Cancel again if current thread also interrupted
>       threadPool.shutdownNow();
>       // Preserve interrupt status
>       Thread.currentThread().interrupt();
>     }
>   }
> {code}
> The {{shutdown}} call does not wait for all submitted tasks to complete, and 
> the {{awaitTermination}} call waits at most 100 seconds. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to