[
https://issues.apache.org/jira/browse/HIVE-16197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974100#comment-15974100
]
Sankar Hariappan commented on HIVE-16197:
-----------------------------------------
Thanks [~sushanth] for the commit!
a) Is there a reason you changed the "replace" field from Boolean to String in
JSONInsertMessage.java ? The change is effectively equivalent and I don't mind,
but is there an issue with the json parsing that you noticed that prompted you
to make that change from .03.patch to .04.patch?
-- No issues with Boolean. But, in many Json message classes, we explicitly
convert fields to String probably due to non-standard types. So, I just
followed the same.
b) In general, I think that when changing thrift structures, it has been
standard practice to always add new fields at the "end", rather than the
beginning - i.e., if a struct already has numbered elements for 1&2, then a new
field should always be added as 3, rather than adding it as 1, and bumping the
prior 1&2 to 2&3. I had to check to see whether doing so breaks backward
compatibility (i.e. is ordering of field numbers important?) and from reading
docs, I can't find anything that indicates that that is a problem, and so the
patch is fine as-is. If there were reason to regenerate this patch, I would
suggest changing it, but at this point, I think it's fine to leave it as-is.
-- Yes, I agree with this. When "replace" field was added initially, it was set
as required field. So, I intended to keep all required fields together. That's
why the ordering looks like this. But, miss to re-order when changed to
optional. Hope, this doesn't have any compatibility issues.
> Incremental insert into a partitioned table doesn't get replicated.
> -------------------------------------------------------------------
>
> Key: HIVE-16197
> URL: https://issues.apache.org/jira/browse/HIVE-16197
> Project: Hive
> Issue Type: Sub-task
> Components: repl
> Affects Versions: 2.1.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Labels: DR
> Fix For: 3.0.0
>
> Attachments: HIVE-16197.01.patch, HIVE-16197.02.patch,
> HIVE-16197.03.patch, HIVE-16197.04.patch
>
>
> Insert to a partitioned table doesn't replicate properly in case of
> incremental dump/load. Few key points to be noted.
> 1. If insert command itself created the new partition, then the inserted row
> is replicated. But the subsequent inserts into the same table doesn't get
> replicated.
> 2. If the partition is created using ALTER TABLE command, then none of the
> inserted rows to this partition is getting replicated. However, the partition
> metadata is getting replicated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
