[ 
https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974167#comment-15974167
 ] 

Zoltan Haindrich commented on HIVE-16355:
-----------------------------------------

[~pvary] I've looked into it...this is something which seemed like a good idea 
when I've written the the patch...but it wouldn't be any better than this; 
doing only this using a serviceloader seems like much more like an overkill; 
than a real good use - since there shouldn't be any users who will implement it 
- because of this the most logical way to handle the case when it detects that 
there are multiple implementations available: would be to throw an exception; 
because that's currently an unexpected situation - however users loading 
service more than once may bump into it...which might seem awkward...

anyway: it seems to me that adding the neccessary interfaces/other stuff would 
just complicate things without adding value....I may possibly come back to it 
later when I've seen more: if I see that it could add real value, I will do it.

> Service: embedded mode should only be available if service is loaded onto the 
> classpath
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-16355
>                 URL: https://issues.apache.org/jira/browse/HIVE-16355
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore, Server Infrastructure
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, 
> HIVE-16355.2.patch
>
>
> I would like to relax the hard reference to 
> {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module 
> is loaded onto the classpath.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to