[
https://issues.apache.org/jira/browse/HIVE-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978832#comment-15978832
]
Peter Vary commented on HIVE-16502:
-----------------------------------
[~kgyrtkirk]: Nice patch, just a few questions:
- Is it intentional that you did not add {{getAuthenticator}},
{{getAuthorizationMode}}, {{isAuthorizationModeV2}}? These are not used by the
classes you refactored, but might be worthwhile candidates to a
{{ISessionAuthState}} interface.
- Just a nit: {{SessionState.java#107}} - there is a missing space.
Thanks,
Peter
> Relax hard dependency on SessionState in Authentication classes
> ---------------------------------------------------------------
>
> Key: HIVE-16502
> URL: https://issues.apache.org/jira/browse/HIVE-16502
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore, Server Infrastructure
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Attachments: HIVE-16502.1.patch
>
>
> It would be better to have the auth system depend on an interface instead the
> whole {{SessionState}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
