[
https://issues.apache.org/jira/browse/HIVE-16534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985262#comment-15985262
]
Wei Zheng commented on HIVE-16534:
----------------------------------
For ValidReadTxnList.isTxnRangeAborted, I think I shouldn't have performed
check for every txn in exceptions. Instead I should just scan every txn from
min to max in the specified range, and for each of them, check if it's aborted
by searching exceptions and the bitset. I corrected that.
I think the override of isTxnRangeAborted in ValidCompactorTxnList is
necessary. The reason is for ValidCompactorTxnList, "exceptions" includes
aborted txns only (see TxnUtils.createValidCompactTxnList). So we don't
maintain a bitset for it as it's not necessary. So in the implementation of
that method we have a slight difference which is we omit the check against the
bitset.
I will add JavaDoc and tests.
> Add capability to tell aborted transactions apart from open transactions in
> ValidTxnList
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-16534
> URL: https://issues.apache.org/jira/browse/HIVE-16534
> Project: Hive
> Issue Type: Bug
> Components: Transactions
> Reporter: Wei Zheng
> Assignee: Wei Zheng
> Attachments: HIVE-16534.1.patch
>
>
> Currently in ValidReadTxnList, open transactions and aborted transactions are
> stored together in one array. That makes it impossible to extract just
> aborted transactions or open transactions.
> For ValidCompactorTxnList this is fine, since we only store aborted
> transactions but no open transactions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
